Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Image Block: Change image by drag & drop an image from the desktop #14983

Merged
merged 1 commit into from
May 1, 2019
Merged

Update: Image Block: Change image by drag & drop an image from the desktop #14983

merged 1 commit into from
May 1, 2019

Conversation

jorgefilipecosta
Copy link
Member

This PR allows images to dragged into the image block that already contains an image. The new image is uploaded and replace the previous one.

cc: @mtias

How has this been tested?

I added an image block; I selected an image from the media gallery.
I dragged an image from the desktop to the image block created on the previous point.
I verified the image was changed.

@jorgefilipecosta jorgefilipecosta added [Type] Enhancement A suggestion for improvement. [Block] Image Affects the Image Block labels Apr 15, 2019
@oandregal oandregal added the [Feature] Drag and Drop Drag and drop functionality when working with blocks label Apr 22, 2019
draganescu
draganescu approved these changes May 1, 2019
View reviewed changes
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as advertised! :)

@draganescu
Copy link
Contributor

Awesome update @jorgefilipecosta! Once this #14918 gets approved (by a review) I could add this behaviour to the gallery, media + text, cover, audio, vide and file blocks. Do you think it's ok to enable drag and drop there too?

@jorgefilipecosta jorgefilipecosta merged commit 6552706 into master May 1, 2019
@jorgefilipecosta jorgefilipecosta deleted the update/allow-change-image-on-the-image-block-by-dragging-an-image-into-the-block branch May 1, 2019 11:18
@jorgefilipecosta
Copy link
Member Author

Thank you for the review @draganescu 👍

I could add this behaviour to the gallery, media + text, cover, audio, vide and file blocks. Do you think it's ok to enable drag and drop there too?

The gallery block already has drag & drop behavior, it appends the dragged images to the gallery, I guess we can leave that behavior.
The cover blocks contain nesting, when we drag an image to a nested area it adds new image block (or gallery) inside that area. Adding drag & drop behavior would collide with the nesting behavior and the result may be uncertain.
The media text also contains nesting but the media element is at the side so I think drag & drop would work well there, and it makes sense to add.
For audio, video and file blocks, it seems like drag & drop to replace totally makes sense, and I'm predicting any potential issue.

@youknowriad youknowriad mentioned this pull request May 6, 2019
Closed
22 tasks
@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019
@swissspidy swissspidy mentioned this pull request May 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draganescu draganescu draganescu approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@gziolo gziolo Awaiting requested review from gziolo

@noisysocks noisysocks Awaiting requested review from noisysocks

@notnownikki notnownikki Awaiting requested review from notnownikki

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
[Block] Image Affects the Image Block [Feature] Drag and Drop Drag and drop functionality when working with blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
5.7 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
4 participants
@jorgefilipecosta @draganescu @youknowriad @oandregal